[10.x] backport src: add node_process.cc#21799
Closed
jasnell wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
[10.x] backport src: add node_process.cc#21799jasnell wants to merge 1 commit intonodejs:v10.x-stagingfrom
jasnell wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: nodejs#21105 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
added
build
addaleax
approved these changes
Jul 13, 2018
Member
Author
targos
approved these changes
Jul 14, 2018
Member
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/15872/ |
Member
|
Got another osx failure. Trying again: https://ci.nodejs.org/job/node-test-pull-request/15874/ |
targos
pushed a commit
that referenced
this pull request
Jul 14, 2018
Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: #21105 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #21799 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21105
Begin moving
processobject function definitions out ofnode.cc... continuing the process of makingnode.ccsmaller and easier to maintain.
PR-URL: #21105
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: Evan Lucas evanlucas@me.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
/cc @addaleax @targos
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes